Fix triggering clippy::mem_forget lint in exported structs
#3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
commented
Jun 12, 2024
| @@ -31,6 +33,7 @@ pub mod final_; | |||
| pub mod futures; | |||
| pub mod gc; | |||
| pub mod getters_and_setters; | |||
| pub mod ignore; | |||
There was a problem hiding this comment.
This was missed back when it was added, its unrelated to this PR.
daxpedda
commented
Jun 12, 2024
| @@ -473,7 +473,7 @@ fn drop_during_call_ok() { | |||
| assert_eq!(x, 3); | |||
|
|
|||
| // make sure `A` is bound to our closure environment. | |||
| drop(&a); | |||
| let _a = &a; | |||
There was a problem hiding this comment.
Just a small improvement.
Also unrelated to this PR.
Liamolucko
approved these changes
Jun 14, 2024
daxpedda
added a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
Jun 19, 2024
ivan-aksamentov
added a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 14, 2024
They fixed this clippy warning: rustwasm/wasm-bindgen#3985
tsibley
pushed a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 15, 2024
They fixed this clippy warning: rustwasm/wasm-bindgen#3985
tsibley
pushed a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 15, 2024
They fixed this clippy warning: rustwasm/wasm-bindgen#3985
tsibley
added a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 16, 2024
…L trust store Previously, the platform's trust store was ignored in favor of a baked in and unconfigurable trust store provided by webpki-roots. Now the reqwest trust store will contain both certs obtained from the platform at run time as well as certs baked in via webpki-roots. Obtaining certs from the platform means that Nextclade will respect OS-level configuration to trust private CAs / self-signed certs. Keeping webpki-roots for all platforms is a precaution that makes this change merely additive for backwards compatibility, in case of platforms which lack a trust store (like some Linux containers) or platforms with out-of-date trust stores. It means that Nextclade binaries should continue to Just Work™. reqwest uses rustls-native-roots to obtain trusted CA certificates from the standard trust stores for the OS/platform. See the crate's documentation for details on each platform.¹ Notably, this does not use the platform's standard certificate verification methods like rustls-platform-verifier; it just extracts certificates. We may in the future want to switch to rustls-platform-verifier (ourselves or by waiting for reqwest to do so). Updates reqwest because an earlier (but problematic and now reverted²) change did so and there were some public API changes I'd like to use. Updates wasm-bindgen as necessary for the newer reqwest (≥0.2.89) and then a little further (0.2.93) to avoid Clippy warnings.³ ¹ <https://docs.rs/crate/rustls-native-certs/0.8.0> ² <#1529 (comment)>. ³ <rustwasm/wasm-bindgen#3985> Resolves: <#726> Related-to: <#1529> Related-to: <#1527>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think its fine to explicitly allow certain lints.
Fixes #3944.